Help me with this script please

alythcott · - Joined: 16 Jul 2003 Posts: 13

[code]
<HTML>
<?php
if ($submit=="Enter information")
{
$db = mysql_connect("localhost", "root","");
mysql_select_db("adsl",$db);
$sql = "INSERT INTO adslinfo (subname, tel, nodename, ISP, downbandwidth, upbandwidth, portnumber, VPI, VCI, VPIVCICPE, LENlogical, LENphysical, provdate) VALUES ('$subname','$tel','$nodename','$ISP','$downbandwidth','$upbandwidth','$portnumber','$VPI','$VCI','$VPIVCICPE','$LENlogical','$LENphysical','$provdate')";
$result = mysql_query($sql);
echo "Thank you! Information entered.\n";
}
else
{
?>
<form method="post" action="input.php">
Subname:<input type="Text" name="subname"><br>
TEL:<input type="Text" name="tel"><br>
Nodename:<input type="Text" name="nodename"><br>
ISP:<input type="Text" name="ISP"><br>
Downbandwidth:<input type="Text" name="downbandwidth"><br>
Upbandwidth:<input type="Text" name="upbandwidth"><br>
Portnumber:<input type="Text" name="portnumber"><br>
VPI:<input type="Text" name="VPI"><br>
VCI:<input type="Text" name="VCI"><br>
VPIVCICPE:<input type="Text" name="VPIVCICPE"><br>
LENlogical:<input type="Text" name="LENlogical"><br>
LENphysical:<input type="Text" name="LENphysical"><br>
Provdate:<input type="Text" name="provdate"><br>
<input type="Submit" name="submit" value="Enter information"></form>
<?
}
?>
</HTML>
[/code]

I keep getting the error below please help

Notice: Undefined variable: submit in C:\Program Files\Abyss Web Server\htdocs\input.php on line 3

docdunning · - Joined: 11 Aug 2003 Posts: 14

When this script is first executed, the variable "$submit" isnt yet defined - that only happens once you've been through once, then submitted the form.

You need to add at the top, something like

if (!isset($submit)) {
$submit = "";
}

Also - its recommended that you use the safer version for posted variables, and not rely on the automatic use of globals, so you'd refer to $_POST['submit'], and the same for all your form variables. This makes it less likely that your script can be hacked by someone entering "scriptname.php?submit=xyz", for example.

alythcott · - Joined: 16 Jul 2003 Posts: 13

On the top where, because i did that and i got a errors